Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-9631

KeyedJoin could miss cache hit, due to uninitialized crc variable.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Not specified
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0
    • Component/s: Thor
    • Labels:
      None

      Description

      Keyed join looks up key parts in a key index cache, using code like:
      unsigned crc=0;
      ..
      ..createKeyIndex(filename.str(), crc, *(lfile.get()), false, false)

      However 'crc' was uninitialized in one case, the key cache uses the filename and crc to create a key for lookup, so the consequence of it being uninitialized here, is that it will likely not match the cached entry and cause new IKeyIndex to be created.

        Attachments

          Activity

            People

            • Assignee:
              jakesmith Jake Smith
              Reporter:
              jakesmith Jake Smith
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: