Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-28598

createStorageApiInfo has the incorrect linkage

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 8.10.10
    • JLib
    • None

    Description

      The function createStorageApiInfo() is declared inside jfile.hpp with jlib_decl, but is defined within rmtfile.cpp.  The definition needs to be moved inside jlib.  Otherwise, a component that links to jlib, but not to remote.dll will compile but fail to link on windows, and give a runtime error on linux.

      It also currently generates a window warning:
       
       

      C:\dev\hpcc\fs\dafsclient\rmtfile.cpp(2599,1): warning C4273: 'createStorageApiInfo': inconsistent dll linkage [C:\Users\gavin\dev\hpcc\build\fs\dafsclient\dafsclient.vcxproj] [build] C:\dev\hpcc\system\jlib\jfile.hpp(478,36): message : see previous definition of 'createStorageApiInfo' [C:\Users\gavin\dev\hpcc\build\fs\dafsclient\dafsclient.vcxproj]  

       

      Attachments

        Activity

          People

            shamser Shamser Ahmed
            ghalliday Gavin Halliday
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: