Details
-
Bug
-
Status: Resolved
-
Blocker
-
Resolution: Fixed
-
None
-
None
-
None
Description
[ 63%] Building CXX object esp/services/ldapenvironment/CMakeFiles/ldapenvironment.dir/ldapenvironmentService.cpp.o
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:257:13: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
if (!req.getGroupsMode() == COUMode_CreateCustom && isEmptyString(req.getCustomGroupsBaseDN()))
^ ~~
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:257:13: note: add parentheses after the '!' to evaluate the comparison first
if (!req.getGroupsMode() == COUMode_CreateCustom && isEmptyString(req.getCustomGroupsBaseDN()))
^
( )
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:257:13: note: add parentheses around left hand side expression to silence this warning
if (!req.getGroupsMode() == COUMode_CreateCustom && isEmptyString(req.getCustomGroupsBaseDN()))
^
( )
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:259:13: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
if (!req.getUsersMode() == COUMode_CreateCustom && isEmptyString(req.getCustomUsersBaseDN()))
^ ~~
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:259:13: note: add parentheses after the '!' to evaluate the comparison first
if (!req.getUsersMode() == COUMode_CreateCustom && isEmptyString(req.getCustomUsersBaseDN()))
^
( )
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:259:13: note: add parentheses around left hand side expression to silence this warning
if (!req.getUsersMode() == COUMode_CreateCustom && isEmptyString(req.getCustomUsersBaseDN()))
^
( )
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:261:13: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
if (!req.getResourcesMode() == COUMode_CreateCustom && isEmptyString(req.getCustomResourcesBaseDN()))
^ ~~
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:261:13: note: add parentheses after the '!' to evaluate the comparison first
if (!req.getResourcesMode() == COUMode_CreateCustom && isEmptyString(req.getCustomResourcesBaseDN()))
^
( )
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:261:13: note: add parentheses around left hand side expression to silence this warning
if (!req.getResourcesMode() == COUMode_CreateCustom && isEmptyString(req.getCustomResourcesBaseDN()))
^
( )
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:263:13: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
if (!req.getWorkunitsMode() == COUMode_CreateCustom && isEmptyString(req.getCustomWorkunitsBaseDN()))
^ ~~
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:263:13: note: add parentheses after the '!' to evaluate the comparison first
if (!req.getWorkunitsMode() == COUMode_CreateCustom && isEmptyString(req.getCustomWorkunitsBaseDN()))
^
( )
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:263:13: note: add parentheses around left hand side expression to silence this warning
if (!req.getWorkunitsMode() == COUMode_CreateCustom && isEmptyString(req.getCustomWorkunitsBaseDN()))
^
( )
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:257:34: error: result of comparison of constant 'COUMode_CreateCustom' (2) with expression of type 'bool' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
if (!req.getGroupsMode() == COUMode_CreateCustom && isEmptyString(req.getCustomGroupsBaseDN()))
~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:259:33: error: result of comparison of constant 'COUMode_CreateCustom' (2) with expression of type 'bool' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
if (!req.getUsersMode() == COUMode_CreateCustom && isEmptyString(req.getCustomUsersBaseDN()))
~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:261:37: error: result of comparison of constant 'COUMode_CreateCustom' (2) with expression of type 'bool' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
if (!req.getResourcesMode() == COUMode_CreateCustom && isEmptyString(req.getCustomResourcesBaseDN()))
~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
/Users/rchapman/HPCC-Platform/esp/services/ldapenvironment/ldapenvironmentService.cpp:263:37: error: result of comparison of constant 'COUMode_CreateCustom' (2) with expression of type 'bool' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
if (!req.getWorkunitsMode() == COUMode_CreateCustom && isEmptyString(req.getCustomWorkunitsBaseDN()))
~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
4 warnings and 4 errors generated.