Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-27607

Obscure crash (memory corruption) in local sort whilst serializing stats.

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Not specified
    • Resolution: Fixed
    • None
    • 7.12.104, 8.6.24, 8.4.42, 8.2.62
    • Thor
    • None

    Description

      This change, https://track.hpccsystems.com/browse/HPCC-23975 (merged into 7.10.0), introduced a window where the activity could stop and clear an object (iLoader), whilst the serialization code was still using it.
      Related - the mergeStats helpers were inadvertently taking a copy of the shared object, and in so doing so linking (and later releasing) - see: HPCC-27606

      Combined with this bug, it could cause heap corruption if the serializeStats call was linking as the stop() thread was destroying the object.

      Fix is to ensure the iLoader.clear() is inside the critical section.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. HPCC-26807 Inquiry History Build(Unexpected process termination)

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. HPCC-26961 Upgrade to 7.12, hash join stopped working - suspected memory corruption in LZ4

          • Not specified - Priority has not been specified
          • New
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. HPCC-27606 mergeStats helpers for Shared<> objects should be based on a const reference, not a copy

          • Not specified - Priority has not been specified
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. HPCC-23975 Refactor Thor activities to use CRuntimeStatisticCollection serialization/deserialization

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            People

              jakesmith Jake Smith
              jakesmith Jake Smith
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: