Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-25686

Thor crash in FileIO->close() since 7.12.32

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.12.32
    • Fix Version/s: 7.12.46
    • Component/s: JLib, Thor
    • Labels:
      None

      Description

      jSince 7.12.32 Thor crashes often in:
      #0 Release<IFileIO> (ptr=0x0) at /home/centos/mkelly/HPCC-Platform/thorlcr/activities/./../../system/jlib/jscm.hpp:46
      #1 ~Shared (this=<optimized out>, __in_chrg=<optimized out)> at /home/centos/mkelly/HPCC-Platform/thorlcr/activities/./../../system/jlib/jscm.hpp:62
      #2 CDiskWriteSlaveActivityBase::close (this=this@entry=0x1080790) at /home/centos/mkelly/HPCC-Platform/thorlcr/activities/thdiskbaseslave.cpp:442
      #3 0x00007f68654d23d4 in CDiskWriteSlaveActivityBase::process (this=0x1080790) at /home/centos/mkelly/HPCC-Platform/thorlcr/activities/thdiskbaseslave.cpp:573
      #4 0x00007f68653fa705 in ProcessSlaveActivity::threadmain (this=0x1080790) at /home/centos/mkelly/HPCC-Platform/thorlcr/slave/slave.cpp:87
      #5 0x00007f685f7ecdf4 in CThreadedPersistent::threadmain (this=0x10809b0) at /home/centos/mkelly/HPCC-Platform/system/jlib/jthread.cpp:591
      #6 0x00007f685f7f3c10 in non-virtual thunk to CThreadedPersistent::CAThread::run() () at /home/centos/mkelly/HPCC-Platform/system/jlib/jthread.hpp:181
      #7 0x00007f685f7ee118 in Thread::begin (this=0x10809b0) at /home/centos/mkelly/HPCC-Platform/system/jlib/jthread.cpp:292
      #8 0x00007f685f7ed79d in Thread::_threadmain (v=0x10809b0) at /home/centos/mkelly/HPCC-Platform/system/jlib/jthread.cpp:138

      (gdb) p tmpFileIO
      $1 = {<Shared<IFileIO>> =

      {ptr = 0x0}

      , <No data fields>}

      There was a change in 7.12.32 related to this area:
      HPCC-25345 Avoid losing write close exceptions

      diff --git a/thorlcr/activities/thdiskbaseslave.cpp b/thorlcr/activities/thdiskbaseslave.cpp
      index d8cc129b4d..3d6be5e444 100644
      --- a/thorlcr/activities/thdiskbaseslave.cpp
      +++ b/thorlcr/activities/thdiskbaseslave.cpp
      @@ -440,6 +440,7 @@ void CDiskWriteSlaveActivityBase::close()
                   tmpFileIO.setown(outputIO.getClear());
               }
               mergeStats(stats, tmpFileIO, diskWriteRemoteStatistics);
      +        tmpFileIO->close(); // NB: close now, do not rely on close in dtor
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mckellyln Mark Kelly
              Reporter:
              mckellyln Mark Kelly
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: