Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-22946

Thor abort code (if deadlocked during shutdown) not working as expected

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.6.2, 7.4.26
    • Fix Version/s: 7.6.4, 7.4.28
    • Component/s: Thor
    • Labels:
      None

      Description

      The abort mechanism introduced by https://github.com/hpcc-systems/HPCC-Platform/pull/13016 , had a couple of typos on if statements, which causes their conditional blocks to always be executed.

      I checked in a debugger, and the consequence is that on shutdown, the 2nd start(), signals the 2nd wait in the thread, and therefore causes the end handler to exit immediately.
      So it would not wait and kill the process as intended, if there was a deadlock during final shutdown.

        Attachments

          Activity

            People

            • Assignee:
              jakesmith Jake Smith
              Reporter:
              jakesmith Jake Smith
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: