Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-22210

Fix uninitialized member causing compiler to spot issues with sanitize checking on

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.4.0
    • Component/s: Thor
    • Labels:
      None

      Description

      thsortu.cpp CJoinHelper, dealing with betweenjoin.

                      case JScompare:                         
                          if (getL()) {
                              rightidx = 0;
                              rightgroupmatched = NULL;
                              if (betweenjoin) {
                                  unsigned nr = 0;
                                  while ((nr<rightgroup.ordinality())&&(btwcompLR.upper->docompare(nextleft,rightgroup.query(nr))>0))
                                      nr++;
                                  rightgroup.removeRows(0,nr);
                                  rightgroupmatched = (bool *)rightgroupmatchedbuf.clear().reserve(rightgroup.ordinality());
                                  memset(rightgroupmatched,rightmatched?1:0,rightgroup.ordinality());
                              }
                              else
                                  rightgroup.kill();
      

      rightmatched is uninitliazed on 1st entry to joinhelper->nextRow().

      However, it probably doesn't have any impact because the rightgroup should be empty.

        Attachments

          Activity

            People

            • Assignee:
              jakesmith Jake Smith
              Reporter:
              jakesmith Jake Smith
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: