Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-21758

Make StringBuffer constructors explicit

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.4.0
    • Component/s: JLib
    • Labels:
      None

      Description

      Tracking down a bug where a call to StringBuffer::append had had no effect, I discovered it was actually creating a temporary StringBuffer object using the StringBuffer(bool) constructor and then passing that to append.

      I tried making all constructors to StringBuffer explicit and found a number of places where the code was not using the pattern (presumably) intended of returning a StringBuffer& reference to a passed in parameter. There were other places where code was not really conforming to our normal style and would have been rather less efficient than intended, and one bit of code where I really don't know WHAT it would have done.

      Needs a full sweep of the code to address all such issues, probably for 7.4.

        Attachments

          Activity

            People

            • Assignee:
              richardkchapman Richard Chapman
              Reporter:
              richardkchapman Richard Chapman
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: