Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-20849

Should c$ and d$ still be in HPCC code...?

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0.2
    • Component/s: Thor
    • Labels:
      None

      Description

      Working with an upgrade from HPCC 5.x to 6.x, I'm getting an error that mentions a "/d$" Linux path.

      Nowhere in environment.xml is "/d$" mentioned.   "Directories" group only designates /var/lib/....

      In searching for references to /d$ and /c$ in HPCC source code, I discovered github does not support searching with special characters like "$".

      However, google.com does support it.  And currently finds "/d$" in apparently "current" code, below.

      Q:  Should this code still be here?  Should any logic be referring to folders with /d$ - Naturally, in some installations (all new ones?), there will be no /c$ or /d$ defined.

       

       

      *https://github.com/hpcc-systems/HPCC-Platform/blob/master/thorlcr/slave/slavmain.cpp*

      line 2301

      void slaveMain(bool &jobListenerStopped)

      { ... ... ... if (getConfigurationDirectory(globals->queryPropTree("Directories"),"mirror","thor",globals->queryProp("@name"),repdir)) overrideReplicateDirectory = repdir.str(); else *overrideReplicateDirectory = "/d$";* setLocalMountRedirect(ip, overrideReplicateDirectory, "/mnt/mirror"); }

       

       

      *https://github.com/hpcc-systems/HPCC-Platform/blob/master/roxie/ccd/ccdmain.cpp*

      line 876

      int STARTQUERY_API start_query(int argc, const char *argv[])
      {
      ...
      ...
      ...
      // MORE: Get parms from topology after it is populated from Hardware/computer types section in configenv
      // Then if does not match and based on desired action in topolgy, either warn, or fatal exit or .... etc
      // Also get prim path and sec from topology
      #ifdef _WIN32
      getHardwareInfo(hdwInfo, "C:", "D:");
      #else // linux
      getHardwareInfo(hdwInfo, "/c$", "/d$");
      #endif
      if (traceLevel)

      { DBGLOG("Current Hardware Info: CPUs=%i, speed=%i MHz, Mem=%i MB , primDisk=%i GB, primFree=%i GB, secDisk=%i GB, secFree=%i GB, NIC=%i", hdwInfo.numCPUs, hdwInfo.CPUSpeed, hdwInfo.totalMemory, hdwInfo.primDiskSize, hdwInfo.primFreeSize, hdwInfo.secDiskSize, hdwInfo.secFreeSize, hdwInfo.NICSpeed); }

      ...

      ...

      ...

       

       

       

       

        Attachments

          Activity

            People

            • Assignee:
              jakesmith Jake Smith
              Reporter:
              jwilt James Wiltshire
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: