Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-20791

Make process should not default to downloading libmemcached sources if libmemcached not found

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.2.0
    • Component/s: Build process
    • Labels:
      None

      Description

      The build process in general should not be downloading at make time.
      Specifically I hit a problem when my Ubuntu 18.04 did not have libmemcached installed and I tried building the platform from clean.
      I hit problems at make time (not cmake time) like this:

      /home/jsmith/dev/git/cmake-debug/downloads/libmemcached/clients/memflush.cc: In function ‘int main(int, char**)’:
      /home/jsmith/dev/git/cmake-debug/downloads/libmemcached/clients/memflush.cc:40:22: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
      if (opt_servers == false)
      

      The make process had downloaded a version of libmemcached that hit compile issues.

      We shouldn't automatically download sources like this.
      If it's an option to download sources, I think it should be at configuration time (e.g. cmake) not make time.

      MEMCACHED_USE_EXTERNAL_LIBRARY should be default to OFF

        Attachments

          Activity

            People

            • Assignee:
              Michael-Gardner Michael Gardner
              Reporter:
              jakesmith Jake Smith
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: