Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-20589 Improve ECL Indexer
  3. HPCC-20684

Minor improvements to the simplified expression flags

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Not specified
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0.0
    • Component/s: eclcc
    • Labels:
      None

      Description

      Two related changes:

       

      a) It would be clearer if ignoreCache was called ignoreSimplified - since it is also use to suppress whether or not a simplified expression that does not come from the cache is used.

       

      b) The code in parseAttribute should only create a simplified definition if it is actually going to be used.  I think that means the test

       

       

          if (canCache && (ctx.syntaxChecking() || ctx.hasCacheLocation()))
      

      should become

          if (canCache && (ctx.syntaxChecking() && (ctx.checkSimpleDef || !ctx.ignoreCache)) || ctx.hasCacheLocation()
      

      possibly with a new ctx method ctx.createSimplified()

       

       

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                shamser Shamser Ahmed
                Reporter:
                ghalliday Gavin Halliday
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: