Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-19948

Consider swapping CActivityFactory and IRoxieServerActivityFactory

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Unresourced
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Roxie
    • Labels:
      None

      Description

      It might be worth swapping the inheritance of CRoxieServerActivityFactoryBase:

          class CRoxieServerActivityFactoryBase : implements IRoxieServerActivityFactory, public CActivityFactory

      instead of

      class CRoxieServerActivityFactoryBase : public CActivityFactory, implements IRoxieServerActivityFactory

       

      It removes the thunks generated when calling methods of IRoxieServerActivityFactory, but would impose a cost when calling down to the base class.  The generated .o/so does shrink with the change in place.  I haven't checked any timings.

       

       

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ghalliday Gavin Halliday
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: