Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-18934

libbase58 uses C99 extensions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0.0
    • Component/s: LibBase58
    • Labels:
      None

      Description

      The code included in libbase58 uses some C99 extensions (variable length arrays) which are not in c++11 (but are allowed by gcc).  This causes the compile to fail under windows.

      uint32_t outi[outisz];

      uint8_t buf[size];

      uint8_t buf[1 + datasz + 0x20];

      It also uses ssize_t.

       

      There should also be some unit tests for the code.

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                afishbeck Anthony Fishbeck
                Reporter:
                ghalliday Gavin Halliday
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: