Uploaded image for project: 'HPCC'
  1. HPCC
  2. HPCC-17798

Fix problems with HPCC-12516

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0.0
    • Component/s: ESP
    • Labels:
      None

      Description

      The PR for HPCC-12516 contains various problems:

      • The system doesn't compile if USE_LIBMEMCACHED is not defined. (HPCC-17797)
      • Various functions are not thread safe. E.g., ensureMemCachedClient(), addMemCachedGlobal, addMemCachedSeconds { setCacheTimeout(value, global) would be a cleaner interface }
      • It wasn't obvious how the timeouts were implemented.
      • queryMemCacheSeconds is casting to unsigned, but returning an int. That will cause warnings on windows.

      Also, the interface should be more abstract that it is. memcached is an implementation detail - it definitely shouldn't be included in the names of the member functions. What happens if we switch from memcached to another implementation?

      memCachedClient should be a pointer to a caching interface.
      ESPMemCached should be an implementation of a general caching interface. There shouldn't be any references to memcached in httptransport.hpp/ipp/cpp.

        Attachments

          Activity

            People

            • Assignee:
              wangkx Kevin Wang
              Reporter:
              ghalliday Gavin Halliday
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: